fix(nes): remove sleep during run for better audio #55
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
Audio on NES wasn't perfect (some audio artifacts / pops), but simply removing the sleep fixes it. I went ahead and removed the associated sleeps within the GBC and SMS components as well.
NOTE: this decreases the measured FPS to 60 on all platforms, but doesn't seem to affect their performance.
Thanks to @danialre for finding out the fix (removing the sleep) over at his fork:
https://github.com/danialre/saintcon2023-emu
How has this been tested?
Building and running on Hardware V0 and playing NES, GBC, and SMS/GG roms.
Screenshots (if appropriate, e.g. schematic, board, console logs, lab pictures):
Types of changes
Checklist:
Software
.github/workflows/build.yml
file to add my new test to the automated cloud build github action.