Feature/metadata modification tracking #59
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
FIT
since it keeps aspect ratio while maximizing the screen utilizationMotivation and Context
Previously, any time you left the settings page to go back to the rom list, it would re-read the metadata file and fully recreate the rom list from scratch, which can take a second or so. This was not a good user experience - esp. if the rom list did not change.
This PR makes the gui track the last modified time of the metadata file, and only if the last modified time is not the same as what we saw last, then we will update the rom list.
How has this been tested?
Building and running on ESP32-S3-BOX with hardware V0 and V1.
Screenshots (if appropriate, e.g. schematic, board, console logs, lab pictures):
Types of changes
Checklist:
Software
.github/workflows/build.yml
file to add my new test to the automated cloud build github action.