Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/metadata modification tracking #59

Merged
merged 5 commits into from
Jan 23, 2024

Conversation

finger563
Copy link
Contributor

Description

  • Update gui to keep track of the last time the metadata file was modified, and only reload the rom list if it has been modified since we loaded it last (e.g. if USB MSC was enabled and it was updated). Keeps the gui from hanging when going from settings page to rom list if the rom list did not need to be regenerated
  • Set default video setting to be FIT since it keeps aspect ratio while maximizing the screen utilization
  • Increased LVGL heap size from 50k to 60k to support additional roms in the rom list

Motivation and Context

Previously, any time you left the settings page to go back to the rom list, it would re-read the metadata file and fully recreate the rom list from scratch, which can take a second or so. This was not a good user experience - esp. if the rom list did not change.

This PR makes the gui track the last modified time of the metadata file, and only if the last modified time is not the same as what we saw last, then we will update the rom list.

How has this been tested?

Building and running on ESP32-S3-BOX with hardware V0 and V1.

Screenshots (if appropriate, e.g. schematic, board, console logs, lab pictures):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Hardware (schematic, board, system design) change
  • Software change

Checklist:

  • My change requires a change to the documentation.
  • I have added / updated the documentation related to this change via either README or WIKI

Software

  • I have added tests to cover my changes.
  • I have updated the .github/workflows/build.yml file to add my new test to the automated cloud build github action.
  • All new and existing tests passed.
  • My code follows the code style of this project.

* Update gui to keep track of the last time the metadata file was modified, and only reload the rom list if it has been modified since we loaded it last (e.g. if USB MSC was enabled and it was updated). Keeps the gui from hanging when going from settings page to rom list if the rom list did not need to be regenerated
@finger563 finger563 added enhancement New feature or request user interface labels Jan 23, 2024
Copy link

✅Static analysis result - no issues found! ✅

@finger563 finger563 merged commit 83abe8e into main Jan 23, 2024
2 checks passed
@finger563 finger563 deleted the feature/metadata-modification-tracking branch January 23, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request user interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant