Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimization: enable QIO mode for flash for faster reading from flash #70

Merged
merged 1 commit into from
Jun 29, 2024

Conversation

finger563
Copy link
Contributor

Description

Set QIO mode for flash in sdkconfig.defaults, which reads from the flash almost twice as fast as the default DIO mode.

Motivation and Context

The faster we read from flash, the faster we load / run code from it. The majority of code we run is coming from flash, so this simple optimization speeds us up a little bit :)

How has this been tested?

Building and running main on box-emu and box-3-emu.

Screenshots (if appropriate, e.g. schematic, board, console logs, lab pictures):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Hardware (schematic, board, system design) change
  • Software change

Checklist:

  • My change requires a change to the documentation.
  • I have added / updated the documentation related to this change via either README or WIKI

Software

  • I have added tests to cover my changes.
  • I have updated the .github/workflows/build.yml file to add my new test to the automated cloud build github action.
  • All new and existing tests passed.
  • My code follows the code style of this project.

@finger563 finger563 self-assigned this Jun 29, 2024
@finger563 finger563 added enhancement New feature or request performance labels Jun 29, 2024
Copy link

✅Static analysis result - no issues found! ✅

@finger563 finger563 merged commit febdf32 into main Jun 29, 2024
3 checks passed
@finger563 finger563 deleted the feature/flash-speedup branch June 29, 2024 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant