This repository has been archived by the owner on May 23, 2024. It is now read-only.
Add support for ESP32-P4 #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
|
Maybe we can merge this without the halt feature for now? We don't have a way to run code on the second core yet anyway. |
|
Given there are not a lot of people able to use it anyway and it shouldn't break anything else I guess I would be fine with it |
|
Sure, will get this rebased in a bit. |
jessebraham
force-pushed
the
feature/esp32p4
branch
from
c2d6bc0
to
1d0f62f
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft for now, haven't finished the
haltfeature. I've implemented how it should look locally, but it seems a bit fishy, so going to take another look in a bit.Otherwise, should be good to go I think.