Add initial support for the ESP32-P4 #1101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Did a quick initial review and everything looks good! Will do a better review on Monday. Tried the hello-world example, and it was working, but I had to use --no-stub even when using latest main of espflash as the current stub of esptool does not work, at least for me (maybe its worth upgrading the custom runner for the time being)
This was referenced Jan 19, 2024
bjoernQ
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't do much of anything yet, but at least allows us to build and flash a simple application.
The
esp32p4-halpackage is currently not being checked by the MSRV job in CI; we need to have some discussion regarding this and update our MSRV and how we check it, but that's outside the scope of this PR.There are a couple git dependencies/patches, but they can all easily be resolved prior to the next release so not gonna worry about them right now.
I have purposefully not documented the features in the module documentation for
esp32p4-hal, I'm currently working on updating these for all packages.