Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESP32-S3: Use 32K ICACHE #1169

Merged
merged 2 commits into from Feb 14, 2024
Merged

ESP32-S3: Use 32K ICACHE #1169

merged 2 commits into from Feb 14, 2024

Conversation

bjoernQ
Copy link
Contributor

@bjoernQ bjoernQ commented Feb 14, 2024

We reserve 32k for the cache but configure the cache to 16k in code. While ideally it should be configurable it should be at least aligned - which is what this PR does.

Trivial code won't see much difference but the difference when using esp-wifi should be huge

Copy link
Member

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@bjoernQ bjoernQ added this pull request to the merge queue Feb 14, 2024
Merged via the queue into esp-rs:main with commit 6e68da0 Feb 14, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants