Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DMA-enable SPI3 on ESP32-S3 #507

Merged
merged 2 commits into from May 4, 2023

Conversation

bjoernQ
Copy link
Contributor

@bjoernQ bjoernQ commented May 3, 2023

Fixes #505

You can test this easily by modifying the spi_loopback_dma by using SPI3 instead of SPI2 in line 74 plus adding a use esp32s3_hal::spi::dma::WithDmaSpi3

Copy link
Member

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@MabezDev MabezDev merged commit 16217b6 into esp-rs:main May 4, 2023
12 checks passed
i404788 pushed a commit to i404788/esp-hal that referenced this pull request Jul 22, 2023
* DMA-enable SPI3 on ESP32-S3

* Make sure to use Spi3Peripheral marker only on S3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ESP32-S3: Missing DMA support from SPI3
2 participants