Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESP32-S3 Octal SPIRAM Support #610

Merged
merged 2 commits into from Jun 22, 2023
Merged

Conversation

bjoernQ
Copy link
Contributor

@bjoernQ bjoernQ commented Jun 21, 2023

This adds support for octal PSRAM on ESP32-S3. Tested with S3Box

Adds new features (opsram_2m, opsram_4m etc.) to activate support.

Fixes #547

@bjoernQ bjoernQ marked this pull request as ready for review June 22, 2023 07:03
Copy link
Contributor

@JurajSadel JurajSadel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I tested the example and it works fine for me.
I left a few notes regarding commented C code (sorry for nitpicking)

esp-hal-common/src/soc/esp32s3/psram.rs Outdated Show resolved Hide resolved
esp-hal-common/src/soc/esp32s3/psram.rs Outdated Show resolved Hide resolved
esp-hal-common/src/soc/esp32s3/psram.rs Outdated Show resolved Hide resolved
esp-hal-common/src/soc/esp32s3/psram.rs Outdated Show resolved Hide resolved
esp-hal-common/src/soc/esp32s3/psram.rs Outdated Show resolved Hide resolved
esp-hal-common/src/soc/esp32s3/psram.rs Outdated Show resolved Hide resolved
Copy link
Member

@jessebraham jessebraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for this!

@jessebraham jessebraham merged commit 9052a39 into esp-rs:main Jun 22, 2023
15 checks passed
MabezDev pushed a commit that referenced this pull request Jul 12, 2023
* ESP32-S3 Octal SPIRAM Support

* Adjust some code comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for OCTAL PSRAM used in ESP32-S3-BOX
3 participants