ESP32-S3 Octal SPIRAM Support - #610
Merged
Merged
Conversation
bjoernQ
force-pushed
the
octal-psram-esp32s3
branch
from
June 22, 2023 06:40
6b653d2 to
36b84cb
Compare
bjoernQ
marked this pull request as ready for review
June 22, 2023 07:03
bjoernQ
force-pushed
the
octal-psram-esp32s3
branch
from
June 22, 2023 07:47
36b84cb to
ceeab6e
Compare
JurajSadel
approved these changes
Jun 22, 2023
JurajSadel
left a comment
JurajSadel
left a comment
Contributor
There was a problem hiding this comment.
LGTM, I tested the example and it works fine for me.
I left a few notes regarding commented C code (sorry for nitpicking)
MabezDev
pushed a commit
that referenced
this pull request
Jul 12, 2023
* ESP32-S3 Octal SPIRAM Support * Adjust some code comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for octal PSRAM on ESP32-S3. Tested with S3Box
Adds new features (
opsram_2m,opsram_4metc.) to activate support.Fixes #547