Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose simple safe wrapper for rssi info #245

Merged
merged 4 commits into from May 4, 2023

Conversation

Vollbrecht
Copy link
Collaborator

addresses Issue: #244

src/wifi.rs Show resolved Hide resolved
src/wifi.rs Show resolved Hide resolved
Copy link
Member

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a few bits to sort out :)

src/wifi.rs Show resolved Hide resolved
src/wifi.rs Show resolved Hide resolved
src/wifi.rs Show resolved Hide resolved
src/wifi.rs Outdated Show resolved Hide resolved
src/wifi.rs Outdated Show resolved Hide resolved
src/wifi.rs Outdated Show resolved Hide resolved
@Vollbrecht Vollbrecht requested a review from MabezDev May 4, 2023 14:39
@Vollbrecht
Copy link
Collaborator Author

fixed mabez comments

Copy link
Member

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@MabezDev MabezDev merged commit b74d98a into esp-rs:master May 4, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants