Skip to content

expose simple safe wrapper for rssi info - #245

Merged
MabezDev merged 4 commits into
esp-rs:masterfrom
Vollbrecht:wifi-signal-strength
May 4, 2023
Merged

expose simple safe wrapper for rssi info#245
MabezDev merged 4 commits into
esp-rs:masterfrom
Vollbrecht:wifi-signal-strength

Conversation

@Vollbrecht

Copy link
Copy Markdown
Collaborator

addresses Issue: #244

Comment thread src/wifi.rs
Comment thread src/wifi.rs

@MabezDev MabezDev left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a few bits to sort out :)

Comment thread src/wifi.rs
Comment thread src/wifi.rs
Comment thread src/wifi.rs
Comment thread src/wifi.rs Outdated
Comment thread src/wifi.rs Outdated
Comment thread src/wifi.rs Outdated
@Vollbrecht
Vollbrecht requested a review from MabezDev May 4, 2023 14:39
@Vollbrecht

Copy link
Copy Markdown
Collaborator Author

fixed mabez comments

@MabezDev MabezDev left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@MabezDev
MabezDev merged commit b74d98a into esp-rs:master May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants