Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESP-IDF 5.2 #416

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

owenthewizard
Copy link
Contributor

ESP-IDF 5.2 adds a new field to the SPI ethernet configurations:

Added option to use SPI Ethernet modules in poll mode without interrupt. #12682 (34ec96e)

So far I have simply added the field and it passes cargo check, but there might be some further changes required?

@ivmarkov
Copy link
Collaborator

CI fails though?

@@ -470,6 +470,11 @@ where
),
)))]
custom_spi_driver: eth_spi_custom_driver_config_t::default(),
#[cfg(all(
Copy link
Collaborator

@ivmarkov ivmarkov Apr 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This condition is not well done (and ditto for all conditions below), in that - once ESP IDF 6.X is out - this will stop working. You probably want to express instead something equivalent to cfg(esp_idf_version >= 5.2).

@owenthewizard
Copy link
Contributor Author

CI fails though?

It seems to me this is because esp-idf-hal needs to be updated as well.

@ivmarkov
Copy link
Collaborator

CI fails though?

It seems to me this is because esp-idf-hal needs to be updated as well.

No. The problem is in eth.rs and seems to come from your changes.

@owenthewizard
Copy link
Contributor Author

CI fails though?

It seems to me this is because esp-idf-hal needs to be updated as well.

No. The problem is in eth.rs and seems to come from your changes.

I can't test the RISC-V targets:

error[E0463]: can't find crate for `core`
  |
  = note: the `riscv32imc-esp-espidf` target may not be installed
  = help: consider downloading the target with `rustup target add riscv32imc-esp-espidf`

@ivmarkov
Copy link
Collaborator

= help: consider downloading the target with rustup target add riscv32imc-esp-espidf

Did you try what the compiler suggested?

@owenthewizard
Copy link
Contributor Author

rustup target add riscv32imc-esp-espidf

Of course...

error: toolchain 'esp' does not support components
error: toolchain 'nightly-x86_64-unknown-linux-gnu' does not support target 'riscv32imc-esp-espidf'

@ivmarkov
Copy link
Collaborator

I think you are NOT really compiling with cargo build -Zbuild-std ..., as you should

Also can you do:

$ rustc --print target-list | grep espidf

It should print something like:

riscv32imac-esp-espidf
riscv32imafc-esp-espidf
riscv32imc-esp-espidf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants