Skip to content
This repository has been archived by the owner on May 15, 2024. It is now read-only.

Add support for the ESP32-H2 #5

Merged
merged 4 commits into from
Jun 9, 2023
Merged

Add support for the ESP32-H2 #5

merged 4 commits into from
Jun 9, 2023

Conversation

jessebraham
Copy link
Member

@jessebraham jessebraham commented Jun 9, 2023

This was thankfully a pretty straight-forward process, but there are some rough edges in this PR I'd like to point out:

  • I had to move esp-backtrace and esp-println to [dependencies], as we're not able to feature-gate dev dependencies.
  • To avoid needing to change .cargo/config.toml when switching chip, I've just generated empty linker scripts for two of the three files on the H2; this is a little hacky, so I'm open to suggestions for better solutions, but it does work.
  • I've changed the channels in all examples to 15; I kept forgetting to change them when I'd switch branches as stuff, makes sense to just keep them all the same to me. If there's any reason not to do this (or if we should use a different channel) please let me know.

I've tested all combination of examples/chips with success:

receive_all_frames receive_frame send_broadcast_frame send_frame
ESP32-C6 -> ESP32-C6 ✅ (C6) ✅ (C6) ✅ (C6) ✅ (C6)
ESP32-C6 -> ESP32-H2 ✅ (H2) ✅ (H2) ✅ (C6) ✅ (C6)
ESP32-H2 -> ESP32-C6 ✅ (C6) ✅ (C6) ✅ (H2) ✅ (H2)
ESP32-H2 -> ESP32-H2 ✅ (H2) ✅ (H2) ✅ (H2) ✅ (H2)

I did have some strange issues while testing, which ultimately resolved themselves, so it wouldn't hurt to do another round.

As I've already mentioned to you, once this PR is merged I'll have a follow-up doing some refactoring/cleanup.

@jessebraham jessebraham requested a review from bjoernQ June 9, 2023 13:11
Copy link
Collaborator

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - also verified with a TI CC2531 sniffer

@bjoernQ bjoernQ merged commit 3796e4f into esp-rs:main Jun 9, 2023
@jessebraham jessebraham deleted the feature/esp32h2 branch June 10, 2023 14:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants