Skip to content
This repository has been archived by the owner on May 15, 2024. It is now read-only.

Refactor the driver #6

Merged
merged 3 commits into from
Jun 13, 2023
Merged

Refactor the driver #6

merged 3 commits into from
Jun 13, 2023

Conversation

jessebraham
Copy link
Member

@jessebraham jessebraham commented Jun 10, 2023

I personally think this cleans things up nicely, but of course open to any feedback you may have!

  • Eliminated the util and utils modules
    • All types/functions inside both were only referenced by single modules, so they were trivial to move
  • Convert the hal module to a directory, move ral inside
    • ral is only ever referened by hal
    • Good separation of concerns to hide away the ral
  • Updated Cargo.toml and README.md, added a few basic doc comments

There aren't any real changes to code here, just shuffling things around. The only changes made were updating import paths as required.

Copy link
Collaborator

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks!

@bjoernQ bjoernQ merged commit a68f163 into esp-rs:main Jun 13, 2023
@jessebraham jessebraham deleted the fixes/refactor branch June 13, 2023 12:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants