Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CoEx support (only works on ESP32-C3 for now), Refactoring #51

Merged
merged 1 commit into from
Sep 8, 2022

Conversation

bjoernQ
Copy link
Contributor

@bjoernQ bjoernQ commented Aug 31, 2022

This PR is huge (sorry) and probably doesn't make sense to read line by line - most important thing is it doesn't make things worse.

This

  • reorganizes code to have BTLE and WiFi more separated, maybe makes adding support for additional chips easier (probably more refactoring needed)
  • introduces two new feature flags to enable ble or wifi - one (or both) features need to be selected to build
  • adds coex support - however it is only working on ESP32-C3 currently
    • since the PR is already huge it makes sense to get this in and look into ESP32 coex later
  • changes the task switching on ESP32 to be much faster

Closes #50 for now

Copy link
Member

@jessebraham jessebraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for taking so long to get to this! I didn't really do a proper code review (there's just too much, don't have the time right now) but it seems to be mostly working on my end. The existing examples for the ESP32 still work, and the ESP32-C3's examples are working... mostly.

For whatever reason, the Wi-Fi and CoEx examples get to this point and just hang:

Lets connect
Lets send
Lets receive

Testing with my mobile hotspot these examples both work again so it's just more network weirdness on my end, but this likely indicates there is some other underlying issue (like the last time we experienced this).

@bjoernQ
Copy link
Contributor Author

bjoernQ commented Sep 8, 2022

Thanks a lot! I guess the examples are just quite bad and sometimes fail. Will have a look at that while working on the next task

@bjoernQ bjoernQ merged commit 1fb0a15 into main Sep 8, 2022
@bjoernQ bjoernQ mentioned this pull request Sep 12, 2022
@bjoernQ bjoernQ deleted the coex_support branch December 16, 2022 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement CoEx
2 participants