Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add socks5 proxy support #423

Merged
merged 1 commit into from
Apr 4, 2024
Merged

Conversation

chenaoxd
Copy link
Contributor

@chenaoxd chenaoxd commented Apr 4, 2024

Added support for SOCKS5 proxy, which is important for users in China.

Copy link
Member

@SergioGasquez SergioGasquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Thanks for your contribution. Mind-expanding how do you plan to use this if/how have you tested this change.

@chenaoxd
Copy link
Contributor Author

chenaoxd commented Apr 4, 2024

We can use the HTTP_PROXY and HTTPS_PROXY environment variables to specify a SOCKS5 proxy. However, if the socks feature in reqwest is not enabled, the proxy settings will not work. This issue is documented at seanmonstar/reqwest#790. I have tested this locally and confirmed that after enabling the socks feature, the SOCKS5 proxy settings function correctly.

Copy link
Member

@SergioGasquez SergioGasquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for adding this feature!

@SergioGasquez SergioGasquez merged commit f25a53d into esp-rs:main Apr 4, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants