Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct Xtensa critical sections #20

Closed
MabezDev opened this issue Jun 20, 2022 · 2 comments
Closed

Correct Xtensa critical sections #20

MabezDev opened this issue Jun 20, 2022 · 2 comments

Comments

@MabezDev
Copy link
Member

The current critical sections are wrong, see esp-rs/esp-hal#87 for more details, the TLDR is that we should not be disabling interrupts. On top of that, we should probably depend on critical_section crate to get the correct per chip implementations, instead of using interrupt::free everywhere.
@MabezDev MabezDev mentioned this issue Jun 20, 2022
Closed
3 tasks
@reitermarkus reitermarkus mentioned this issue Aug 24, 2022
Merged
@reitermarkus
Copy link

Is this closed by esp-rs/esp-hal#151?

bors bot added a commit to rust-embedded/svd2rust that referenced this issue Aug 24, 2022
@bors @reitermarkus
Merge #651
7daa9ed 
651: Use `critical_section` for `Peripherals::take`. r=therealprof a=reitermarkus

- `cortex_m` rust-embedded/cortex-m#447
- `msp430` rust-embedded/msp430#13
- `riscv` rust-embedded/riscv#110
-  `xtensa_lx` esp-rs/xtensa-lx#20, esp-rs/esp-hal#151
- `mips_mcu` kiffie/pic32-rs#5


Co-authored-by: Markus Reiter <me@reitermark.us>
@MabezDev
Copy link
Member Author

Yes, thanks for the ping @reitermarkus!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
esp-rs
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@reitermarkus @MabezDev