This repository has been archived by the owner on Jul 17, 2024. It is now read-only.
Correct Xtensa critical sections #20
Comments
3 tasks
|
Is this closed by esp-rs/esp-hal#151? |
bors bot
added a commit
to rust-embedded/svd2rust
that referenced
this issue
Aug 24, 2022
651: Use `critical_section` for `Peripherals::take`. r=therealprof a=reitermarkus - `cortex_m` rust-embedded/cortex-m#447 - `msp430` rust-embedded/msp430#13 - `riscv` rust-embedded/riscv#110 - `xtensa_lx` esp-rs/xtensa-lx#20, esp-rs/esp-hal#151 - `mips_mcu` kiffie/pic32-rs#5 Co-authored-by: Markus Reiter <me@reitermark.us>
|
Yes, thanks for the ping @reitermarkus! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
The current critical sections are wrong, see esp-rs/esp-hal#87 for more details, the TLDR is that we should not be disabling interrupts. On top of that, we should probably depend on
critical_sectioncrate to get the correct per chip implementations, instead of usinginterrupt::freeeverywhere.The text was updated successfully, but these errors were encountered: