Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

advertise all hosted services #1451

Merged
merged 4 commits into from Jan 18, 2016
Merged

advertise all hosted services #1451

merged 4 commits into from Jan 18, 2016

Conversation

probonopd
Copy link
Contributor

Make the OTA port appear in the IDE (without having to restart it) and make it show up in avahi-browse -a. Thanks to @me-no-dev for writing this patch.

@igrr
Copy link
Member

igrr commented Jan 16, 2016

This new method should probably be protected/private, because it's only called internally.

@probonopd
Copy link
Contributor Author

Thanks, updated the PR.

@me-no-dev
Copy link
Collaborator

I think it should stay public :) could be needed if services change maybe readvertisement... Etc
Move to private if proven unnecessary

igrr added a commit that referenced this pull request Jan 18, 2016
advertise all hosted services
@igrr igrr merged commit 8c3e1d0 into esp8266:master Jan 18, 2016
@probonopd probonopd deleted the patch-2 branch January 18, 2016 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants