Extend Print class for 64bit integers. #7040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d-a-v
approved these changes
Jan 28, 2020
|
On AVR (arduino/ArduinoCore-avr#312) it's different from Xtensa, I've now optimized both PRs for size, thanks for asking the question. |
devyte
requested changes
Feb 1, 2020
dok-net
force-pushed
the
print64bit
branch
4 times, most recently
from
76acf6c
to
127e75f
Compare
devyte
requested changes
Apr 18, 2020
|
@dok-net just the one change and this is good from me. |
|
Built binary size remains unchanged.
|
|
This today got merged in Arduino Core for ESP32 master, espressif/arduino-esp32#3688 |
…t(...). Move template defintion into cpp file - valid for private member function templates.
devyte
approved these changes
Oct 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@d-a-v We've talked about it yesterday. Even if PR'ing AVR Arduino is a good idea to do first|also, could you give this an eye, please?
Compiled size is not affected if not used with (u)int64_t, if print(int64_t) gets used, 288 bytes IROM are used additionally.