Add valgrind mocked test to CI #7501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Run valgrind on host mock example runs to catch more bugs in CI. These tests would have caught the problem in esp8266#7464 before users did. Add a list of some randomly picked examples to run, and add an option to run the loop exactly once in the host mock routine, so the test will actually exit under valgrind.
d-a-v
reviewed
Aug 3, 2020
| ../../libraries/SD/examples/Files/Files \ | ||
| ../../libraries/LittleFS/examples/LittleFS_Timestamp/LittleFS_Timestamp \ | ||
| ../../libraries/LittleFS/examples/SpeedTest/SpeedTest ; do | ||
| make -j2 D=1 $i |
There was a problem hiding this comment.
In a 64-bits gcc-multilib environment, 32 bits binaries are generated by default but valgrind does not work with them. FORCE32=0 disables that and 64 bits binaries are generated.
In a non-gcc-multilib 64-bits environment, everything is 64 bits.
Just in case, I would make -j2 D=1 FORCE32=0 $i
d-a-v
approved these changes
Aug 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run valgrind on host mock example runs to catch more bugs in CI. These
tests would have caught the problem in #7464 before users did.
Add a list of some randomly picked examples to run, and add an option to
run the loop exactly once in the host mock routine, so the test will
actually exit under valgrind.