Support for Xextan Language #1881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. Things to do before approval: |
|
Also: include the language in the windows build files in src/windows as well |
|
I believe the branch is ready for inspection. Do let me know if I've missed anything. |
|
I've added an appropriate phoneme test for Xextan, which should hopefully resolve the failed checks. |
|
My apologies! I seemed to have fumbled my phone and accidentally closed the pull request for a minute. |
|
In any case, the five checks that failed the last time around seem to have been inherited from the main branch. |
|
Can you do one more rebase for your branch? Unfortunately for you, this was the last PR of the three incoming new languages |
|
Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Data for the constructed art language Xextan, adapted for current version of eSpeak-NG.