Implement horse-hoarse merger for en-US / general american #1901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Dear @rhdunn, I hope you're the right person to ask, could you please review this PR? Kind regards, |
Draft
|
hello @danielwinkler can you look at the failing checks? |
|
Hi @alex19EP I updated the expected values for the failing en-US tests, you can see it 1 time in plain text, another time it is caused by the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in general american, for and four are homophones, see
https://en.wiktionary.org/wiki/four#Pronunciation_2
https://en.wiktionary.org/wiki/for#Pronunciation
This is due to the horse-hoarse merger, see
https://en.wikipedia.org/wiki/English-language_vowel_changes_before_historic_/r/#Horse%E2%80%93hoarse_merger
This PR accompanies for this merger on the pronunciation level.