Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dictsource/hu_rules: added newest exceptions (june 19 state collection) #1932

Closed
wants to merge 0 commits into from

Conversation

hammera
Copy link
Contributor

@hammera hammera commented Jun 19, 2024

Hy Boys,

If anybody have a little time please merge this PR to the master branch.
I updated the dictsources/hu_rules file, simple added newest hungarian pronounce rule exceptions.

Thanks the future merge,

Attila

@hammera
Copy link
Contributor Author

hammera commented Jun 19, 2024

I don't no why produce Github workflows failures, usual wallgrind checks.
My machine the ./autogen.sh, ./configure, make command ran successfull.
The espeak-ng --compile=hu command ran succesfull too the dictsource directory.

Attila

@hammera hammera force-pushed the update_hungarian_rules branch 2 times, most recently from 7cc1659 to c7b4362 Compare June 21, 2024 17:35
@hammera
Copy link
Contributor Author

hammera commented Jun 22, 2024

Boys, happened a code change with affects this five failing workflows?
I tryed now to put extra slash characters before documentation comments the exceptions, but not help.
dictsource/hu_rules absolute sure sintax level right, works both old Espeak, new stable Espeak-ng and master branch of espeak-ng when I use --compile=hu command the dictsource directory.
When I ran simple ./autogen.sh, ./configure, make commands, the hungarian dictionary binary files generated right.
Me not have better ydea with hu_rules level.
Perhaps changed anything the Github workflow run systems with affects this five workflows?
Other PR's are produce this failures too?
You what expecting?

Attila

@hammera hammera force-pushed the update_hungarian_rules branch 3 times, most recently from b069e3e to b760577 Compare June 25, 2024 12:39
@hammera
Copy link
Contributor Author

hammera commented Jun 27, 2024

I looked Ubuntu AMD64 clang+msan test result.
Very interesting the output, but I don't no what changed into the Espeak-ng code base to this test failing (the 18th test crashing I think).
Looks the log result:


Skip to content
Navigation Menu

Code
Issues 462
Pull requests 29
Discussions
Actions
Wiki

Back to pull request #1932
dictsource/hu_rules: added newest exceptions (june 19 state collection) #1655
ubuntu amd64: clang + msan
failed Jun 25, 2024 in 2m 10s
1s
41s
10s
0s
3s
0s
0s
4s
16s
0s
27s
9s
18s
      Start 17: voices
10/19 Test #10: language-numbers-ordinal ...................   Passed    1.40 sec
      Start 18: crash
11/19 Test #17: voices .....................................   Passed    0.19 sec
      Start 19: klatt
12/19 Test #18: crash ......................................***Failed    0.50 sec
testing CVE-cve-2023-49990
==5675==WARNING: MemorySanitizer: use-of-uninitialized-value
    #0 0x55bb045e1b61 in TranslateRules /home/runner/work/espeak-ng/espeak-ng/src/libespeak-ng/dictionary.c:2081:7
    #1 0x55bb0464e442 in TranslateWord3 /home/runner/work/espeak-ng/espeak-ng/src/libespeak-ng/translateword.c:313:15
    #2 0x55bb0463b57b in TranslateWord /home/runner/work/espeak-ng/espeak-ng/src/libespeak-ng/translate.c:150:14
    #3 0x55bb046471ad in TranslateWord2 /home/runner/work/espeak-ng/espeak-ng/src/libespeak-ng/translate.c:404:11
    #4 0x55bb04644853 in TranslateClauseWithTerminator /home/runner/work/espeak-ng/espeak-ng/src/libespeak-ng/translate.c:1613:6
    #5 0x55bb0464aa7a in TranslateClause /home/runner/work/espeak-ng/espeak-ng/src/libespeak-ng/translate.c:1679:2
    #6 0x55bb04631635 in SpeakNextClause /home/runner/work/espeak-ng/espeak-ng/src/libespeak-ng/synthesize.c:1560:2
    #7 0x55bb04670093 in Synthesize /home/runner/work/espeak-ng/espeak-ng/src/libespeak-ng/speech.c:489:9
    #8 0x55bb046712fb in espeak_ng_Synthesize /home/runner/work/espeak-ng/espeak-ng/src/libespeak-ng/speech.c
    #9 0x55bb046728e3 in espeak_Synth /home/runner/work/espeak-ng/espeak-ng/src/libespeak-ng/espeak_api.c:90:32
    #10 0x55bb045a8fd4 in main /home/runner/work/espeak-ng/espeak-ng/src/espeak-ng.c:779:3
    #11 0x7fd124429d8f in __libc_start_call_main csu/../sysdeps/nptl/libc_start_call_main.h:58:16
    #12 0x7fd124429e3f in __libc_start_main csu/../csu/libc-start.c:392:3
    #13 0x55bb0451e4c4 in _start (/home/runner/work/espeak-ng/espeak-ng/build/src/espeak-ng+0x284c4) (BuildId: 23cc988d26aa8a1740f89fbc67936cfd5b97e00e)

  Uninitialized value was created by an allocation of 'number_buf' in the stack frame of function 'TranslateClauseWithTerminator'
    #0 0x55bb0463c670 in TranslateClauseWithTerminator /home/runner/work/espeak-ng/espeak-ng/src/libespeak-ng/translate.c:925

SUMMARY: MemorySanitizer: use-of-uninitialized-value /home/runner/work/espeak-ng/espeak-ng/src/libespeak-ng/dictionary.c:2081:7 in TranslateRules
Exiting

13/19 Test #19: klatt ......................................   Passed    0.53 sec
14/19 Test  #8: dictionary .................................   Passed    2.51 sec
15/19 Test #14: ssml .......................................   Passed    2.08 sec
16/19 Test  #9: language-numbers-cardinal ..................   Passed    2.98 sec
17/19 Test #15: translate ..................................   Passed    3.83 sec
18/19 Test #12: language-pronunciation .....................   Passed    9.86 sec
19/19 Test #11: language-phonemes ..........................   Passed   12.44 sec

95% tests passed, 1 tests failed out of 19

Total Test time (real) =  12.64 sec

The following tests FAILED:
	 18 - crash (Failed)
Errors while running CTest
Error: Process completed with exit code 8.

So, this issue is sure independent I think the hu_rules change.
I looked three time the entire patch, but I don't see any suspicious change the rules file related with resulting this type test failure.

Attila

@hammera hammera force-pushed the update_hungarian_rules branch 2 times, most recently from 6affeec to 88e284b Compare June 29, 2024 13:03
@hammera
Copy link
Contributor Author

hammera commented Jun 30, 2024

Boys, don't surprise, becausa always this PR producing 5 failing checks (or an another thing with differents this pull request, temporary I will be reweerting the hu_rules related commit to I see without this language file related update all checks are passed or not.
Me not have better ydea. :-(:-(
If the workflows not failing if this commit are not present, I remove this patch the documentation comments, and again committing the change without documentation comments.

Attila

@hammera
Copy link
Contributor Author

hammera commented Jun 30, 2024

My good, I don't want close this PR. :-(:-(
Sorry the unwanted close.

Attila

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant