Skip to content
This repository has been archived by the owner on Dec 30, 2023. It is now read-only.

Support of special characters in filenames #8

Closed
vikbez opened this issue Mar 25, 2016 · 4 comments
Closed

Support of special characters in filenames #8

vikbez opened this issue Mar 25, 2016 · 4 comments

Comments

@vikbez
Copy link

vikbez commented Mar 25, 2016

"é.png" is impossible to upload (infinite wait)

@espebra
Copy link
Owner

espebra commented Mar 25, 2016

I'll look into it. Thank you for the bug report.

espebra added a commit that referenced this issue Mar 27, 2016
This is a simple workaround for #8. It will simply replace characters
considered as invalid with the character _ on the client side. Longer
explaination follows.

Filebin currently uses a client request header to specify the filename.
The filename is limited to ascii characters since request headers are
limited to ascii characters by RFC 822. Proper UTF 8 support will
require a bigger change, possibly including on or both of the following:

1) Transfer the filename using form data instead of a request header.

2) Base64 encode the filename.

It is tempting to use a combination of both, and even to store the files
in the filesystem with base64 encoded names. This will make it possible
to support "folder like" filenames (including /). As mentioned, this is
a bigger change that will require a bit of work and will break the API.
@espebra
Copy link
Owner

espebra commented Mar 27, 2016

I've implemented a workaround in master which is deployed to http://dev.filebin.net/ now. It is not yet fixed on http://filebin.net/.

Did you experience this in a self hosted environment or on http://filebin.net/? If self hosted, is it based on master or the python branch?

@vikbez
Copy link
Author

vikbez commented Mar 27, 2016

self hosted, on golang version (master branch)
patch seems ok !
👍

@espebra
Copy link
Owner

espebra commented Mar 27, 2016

Ok. Then I'll skip backporting it to the Python version.

@espebra espebra closed this as completed Mar 27, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants