Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_evilES3SafeReExports: Fix ES3 syntax error for default re-exporting #176

Merged
merged 1 commit into from
Jul 29, 2015

Conversation

XrXr
Copy link
Contributor

@XrXr XrXr commented Jul 12, 2015

Fixes #175

@stefanpenner
Copy link
Contributor

👍

@XrXr
Copy link
Contributor Author

XrXr commented Jul 23, 2015

@Rich-Harris could you review this please? We, and I think many others are waiting for this to be merged so It can be fixed in Ember CLI so we can support IE8 on its way out.

@stefanpenner
Copy link
Contributor

@Rich-Harris could you review this? We, and I think many others are waiting for this to be merged so It can be fixed in Ember CLI so we can support IE8 on its way out.

please note, it appears the windows tests are failing. Could you look into this?

@XrXr
Copy link
Contributor Author

XrXr commented Jul 23, 2015

@stefanpenner I looked at the console output from appveyor. nodejs_version=0.10 and nodejs_version=0.12 couldn't connect to Github. The one that has failed tests is nodejs_version=1.0

AFAIK Node.js doesn't have a 1.0 at the moment. Is it IO.js?

@XrXr
Copy link
Contributor Author

XrXr commented Jul 23, 2015

I looked into it a little, I think the failed tests are inherited from master.

https://ci.appveyor.com/project/eventualbuddha/esperanto/build/1.0.181

I ran the console output of the master branch build and the build for this PR through a difftool, and the fail messages are exactly the same.

@stefanpenner
Copy link
Contributor

@eventualbuddha can we move this forward?

@stefanpenner
Copy link
Contributor

I now have commit and publish, so lets get this moving.

It does appear like the appveyor build has never passed. So it should not block this bugfix.

stefanpenner added a commit that referenced this pull request Jul 29, 2015
_evilES3SafeReExports: Fix ES3 syntax error for default re-exporting
@stefanpenner stefanpenner merged commit 4323081 into esperantojs:master Jul 29, 2015
@alexlafroscia
Copy link

For people seeing issues with the Ember CLI that this should fix, what would be the right way to get this patch now?

PS: Thanks for pulling this 😀

@stefanpenner
Copy link
Contributor

For people seeing issues with the Ember CLI that this should fix, what would be the right way to get this patch now?

tricky, it appears something if wrong with esperantos build preventing me from releasing.

I would suggest just running your prod build output through https://github.com/stefanpenner/es3-safe-recast as a workaround

@alexlafroscia
Copy link

Alright, thanks! I'll keep an eye open for an Esperanto update in the near future, too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants