-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
_evilES3SafeReExports: Fix ES3 syntax error for default re-exporting #176
Conversation
👍 |
@Rich-Harris could you review this please? We, and I think many others are waiting for this to be merged so It can be fixed in Ember CLI so we can support IE8 on its way out. |
please note, it appears the windows tests are failing. Could you look into this? |
@stefanpenner I looked at the console output from appveyor. AFAIK Node.js doesn't have a 1.0 at the moment. Is it IO.js? |
I looked into it a little, I think the failed tests are inherited from https://ci.appveyor.com/project/eventualbuddha/esperanto/build/1.0.181 I ran the console output of the master branch build and the build for this PR through a difftool, and the fail messages are exactly the same. |
@eventualbuddha can we move this forward? |
I now have commit and publish, so lets get this moving. It does appear like the appveyor build has never passed. So it should not block this bugfix. |
_evilES3SafeReExports: Fix ES3 syntax error for default re-exporting
For people seeing issues with the Ember CLI that this should fix, what would be the right way to get this patch now? PS: Thanks for pulling this 😀 |
tricky, it appears something if wrong with esperantos build preventing me from releasing. I would suggest just running your prod build output through https://github.com/stefanpenner/es3-safe-recast as a workaround |
Alright, thanks! I'll keep an eye open for an Esperanto update in the near future, too. |
Fixes #175