Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix setState warning when component unmounts #4

Merged
merged 1 commit into from
Aug 4, 2017

Conversation

danielr18
Copy link
Contributor

The component should avoid calling setState() after it has unmounted, which can happens before the request is completed.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.8%) to 96.429% when pulling 0535813 on danielr18:master into 147eab1 on esphen:master.

@eliihen
Copy link
Owner

eliihen commented Aug 4, 2017

Awesome! The diff looks great.

I'll merge and get this out in 0.2.1 shortly

Thanks!

@eliihen eliihen merged commit 10b0570 into eliihen:master Aug 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants