Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase expected disconnect cooldown to 5.0 seconds #540

Merged
merged 1 commit into from Sep 6, 2023
Merged

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Sep 5, 2023

Since the connect logic is much faster now we might be reconnecting before the device goes into deep sleep after an expected disconnect. Increase the expected disconnect cooldown from 3.0s to 5.0s

related issue home-assistant/core#98221

The 3.0s cooldown was chosen in #397 for similar reasons (but the reconnect logic was slower than)

Since the connect logic is much faster now we might be
reconnecting before the device goes into deep sleep after
an expected disconnect. Increase the expected disconnect
cooldown from 3.0s to 5.0s

related issue home-assistant/core#98221
@bdraco bdraco marked this pull request as ready for review September 6, 2023 00:22
@bdraco bdraco merged commit 223eb23 into main Sep 6, 2023
7 checks passed
@bdraco bdraco deleted the cooldown branch September 6, 2023 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant