DO NOT MERGE: Test disabling keep alives #596
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is manual testing to see if https://community.home-assistant.io/t/esphome-didnt-respond-to-ping-request-in-time-disconnecting/608538/17 can be replicated
Codecov Report
@@ Coverage Diff @@
## main #596 +/- ##
==========================================
- Coverage 70.22% 70.04% -0.18%
==========================================
Files 14 14
Lines 2438 2437 -1
==========================================
- Hits 1712 1707 -5
- Misses 726 730 +4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
I figured disabling the keep alives would show if we had a bug in this lib but everything seems ok so likely a network issue or the ESP itself isn't actually sending the ping request (or processing the response) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is manual testing to see if
https://community.home-assistant.io/t/esphome-didnt-respond-to-ping-request-in-time-disconnecting/608538/17 can be replicated