Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dialout permissions instructions to no-port #427

Merged
merged 4 commits into from
Feb 10, 2024

Conversation

SirGoodenough
Copy link
Contributor

I didn't have a way to test the code or build this.
Please do a code review.

This adds a message for Linux users having problems getting the WebTools to grab a port.

@balloob
Copy link
Member

balloob commented Nov 4, 2023

We should only show this message if we know that the user is using a Linux platform. You can test for that using /Linux/.test(navigator.platform)

@SirGoodenough
Copy link
Contributor Author

SirGoodenough commented Nov 9, 2023

And likewise we should only send windows messages if the user is on a windows platform, etc.
I personally don't know how to pull that off.
If there is someone that can do this now, great.
Otherwise what's one more message in that stack?

This problem had me stuck for a long time, like a year. I hate windows that much...
Jessie got me going finally when I b**** about it on the last release party.

And I found this showing that command is deprecated...
https://developer.mozilla.org/en-US/docs/Web/API/Navigator/platform

Which says that construct is deprecated.

@RosemaryOrchard
Copy link

@SirGoodenough
Copy link
Contributor Author

Thanks for the link. I read that over and still have no clue what to do with it.
I'm looking for someone that can pull this off.

Copy link
Member

@balloob balloob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@balloob balloob merged commit 21c2320 into esphome:main Feb 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants