Switch to preset-env for babel #476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the Material Web components use JavaScript syntax that didn't get compiled, which broke unpkg. Unpkg is what we have always suggested as CDN to use for integrating ESP Web Tools on websites.
I put #475 in place to fix that. However, this can cause another breakage if another modern syntax slips in. To avoid this, this PR adds @babel/preset-env and targets Chrome 84.
Chrome 84 is the last version to not support local assignment.
We don't know the exact max version of Chrome that unpkg supports, but this should be a good safe first version.