Skip to content
This repository has been archived by the owner on Sep 27, 2023. It is now read-only.

Fix neopixelbus logging causes section type conflict #579

Merged
merged 2 commits into from
Mar 31, 2019
Merged

Fix neopixelbus logging causes section type conflict #579

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
17f52a4
Fix neopixelbus logging causes section type conflict
OttoWinter Mar 31, 2019
ad674fc
Lint
OttoWinter Mar 31, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions src/esphome/light/neo_pixel_bus_light_output.tcc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,6 @@ void NeoPixelBusLightOutputBase<T_METHOD, T_COLOR_FEATURE>::add_leds(
}
template<typename T_METHOD, typename T_COLOR_FEATURE>
void NeoPixelBusLightOutputBase<T_METHOD, T_COLOR_FEATURE>::setup() {
ESP_LOGCONFIG(TAG, "Setting up NeoPixelBus light...");
for (int i = 0; i < this->size(); i++) {
(*this)[i] = ESPColor(0, 0, 0, 0);
}
Expand All @@ -59,10 +58,7 @@ void NeoPixelBusLightOutputBase<T_METHOD, T_COLOR_FEATURE>::setup() {
this->controller_->Begin();
}
template<typename T_METHOD, typename T_COLOR_FEATURE>
void NeoPixelBusLightOutputBase<T_METHOD, T_COLOR_FEATURE>::dump_config() {
ESP_LOGCONFIG(TAG, "NeoPixelBus light:");
ESP_LOGCONFIG(TAG, " Num LEDs: %u", this->controller_->PixelCount());
}
void NeoPixelBusLightOutputBase<T_METHOD, T_COLOR_FEATURE>::dump_config() {}
template<typename T_METHOD, typename T_COLOR_FEATURE>
void NeoPixelBusLightOutputBase<T_METHOD, T_COLOR_FEATURE>::loop() {
if (!this->should_show_())
Expand Down Expand Up @@ -92,7 +88,6 @@ void NeoPixelBusLightOutputBase<T_METHOD, T_COLOR_FEATURE>::loop() {
}
#endif

ESP_LOGVV(TAG, "Writing RGB values to bus...");
this->controller_->Show();
}
template<typename T_METHOD, typename T_COLOR_FEATURE>
Expand Down