Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs for Xiaomi Miscale v1 and v2 #1021

Merged
merged 2 commits into from
Feb 22, 2021
Merged

Add docs for Xiaomi Miscale v1 and v2 #1021

merged 2 commits into from
Feb 22, 2021

Conversation

dckiller51
Copy link
Contributor

@dckiller51 dckiller51 commented Feb 20, 2021

Description:

Doc for Scale Xiaomi Miscale v1 ans v2

Pull request in esphome with YAML changes (if applicable): esphome/esphome#1368

Checklist:

  • Branch: next is for changes and new documentation that will go public with the next ESPHome release. Fixes, changes and adjustments for the current release should be created against current.
  • Link added in /index.rst when creating new documents for new components or cookbook.

Copy link
Member

@jesserockz jesserockz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few changes to make please

components/sensor/xiaomi_miscale.rst Outdated Show resolved Hide resolved
components/sensor/xiaomi_miscale2.rst Outdated Show resolved Hide resolved
index.rst Outdated Show resolved Hide resolved
index.rst Outdated Show resolved Hide resolved
Copy link
Member

@jesserockz jesserockz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go. Thanks

@jesserockz jesserockz changed the title add doc xiaomi miscale v1/v2 Add docs for Xiaomi Miscale v1 and v2 Feb 22, 2021
@jesserockz jesserockz merged commit 3cb84bb into esphome:next Feb 22, 2021
This was referenced Mar 22, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Oct 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants