Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarification of the behavior of calibraty_linear filter #1701

Merged
merged 2 commits into from
Jan 21, 2022

Conversation

swifty99
Copy link
Contributor

@swifty99 swifty99 commented Dec 5, 2021

Description:

I was misunderstood, how calibrate linear works. I found others having the same trouble. Here is my first contribution to the documentation. So, please be gentle. ;-)

Related issue (if applicable): fixes (esphome/issues#2768)

Pull request in esphome with YAML changes (if applicable): esphome/esphome#

Checklist:

  • Branch: next is for changes and new documentation that will go public with the next ESPHome release. Fixes, changes and adjustments for the current release should be created against current.
  • Link added in /index.rst when creating new documents for new components or cookbook.

Copy link
Contributor

@flaviut flaviut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what this is saying, but I believe it should:

  • either be shortened to "So you must supply at exactly two values."
  • describe the actual behavior when more than two values are passed

@swifty99
Copy link
Contributor Author

It is allowed to use more than two values. Which was confusing me, that could be changed on code side.

If that change is unwanted how about this:
"if more than two values are given an exact representation on each value will not be found unless they form a line."
or
"if more than two values are given a linear solution will be calculated and will not represent each value exactly"

looking good

Co-authored-by: Flaviu Tamas <me@flaviutamas.com>
@netlify
Copy link

netlify bot commented Jan 11, 2022

✔️ Deploy Preview for esphome ready!

🔨 Explore the source changes: 9e4e7e1

🔍 Inspect the deploy log: https://app.netlify.com/sites/esphome/deploys/61ddafc610eb820008344847

😎 Browse the preview: https://deploy-preview-1701--esphome.netlify.app

@flaviut flaviut merged commit b7b082c into esphome:current Jan 21, 2022
flaviut added a commit to flaviut/esphome-docs that referenced this pull request Jan 21, 2022
flaviut added a commit that referenced this pull request Jan 21, 2022
cstaahl pushed a commit to cstaahl/esphome-docs that referenced this pull request Jan 21, 2022
dav-id-org pushed a commit to dav-id-org/esphome-docs that referenced this pull request Jan 22, 2022
dav-id-org pushed a commit to dav-id-org/esphome-docs that referenced this pull request Jan 22, 2022
dav-id-org added a commit to dav-id-org/esphome-docs that referenced this pull request Jan 22, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jan 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants