-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarification of the behavior of calibraty_linear filter #1701
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure what this is saying, but I believe it should:
- either be shortened to "So you must supply at exactly two values."
- describe the actual behavior when more than two values are passed
It is allowed to use more than two values. Which was confusing me, that could be changed on code side. If that change is unwanted how about this: |
looking good Co-authored-by: Flaviu Tamas <me@flaviutamas.com>
✔️ Deploy Preview for esphome ready! 🔨 Explore the source changes: 9e4e7e1 🔍 Inspect the deploy log: https://app.netlify.com/sites/esphome/deploys/61ddafc610eb820008344847 😎 Browse the preview: https://deploy-preview-1701--esphome.netlify.app |
Requested here: esphome#1701 (comment)
…home#1701)" This reverts commit b7b082c.
Description:
I was misunderstood, how calibrate linear works. I found others having the same trouble. Here is my first contribution to the documentation. So, please be gentle. ;-)
Related issue (if applicable): fixes (esphome/issues#2768)
Pull request in esphome with YAML changes (if applicable): esphome/esphome#
Checklist:
next
is for changes and new documentation that will go public with the next ESPHome release. Fixes, changes and adjustments for the current release should be created againstcurrent
./index.rst
when creating new documents for new components or cookbook.