Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ifan02 cookbook #218

Merged
merged 15 commits into from
Apr 5, 2020
Merged

ifan02 cookbook #218

merged 15 commits into from
Apr 5, 2020

Conversation

quazzie
Copy link
Contributor

@quazzie quazzie commented Apr 4, 2019

Description:

Sonoff ifan02 cookbook.
It is not pretty but the info is correct.

Related issue (if applicable): fixes

Pull request in esphome with YAML changes (if applicable): esphome/esphome#
Pull request in esphome-core with C++ framework changes (if applicable): esphome/esphome-core#

Checklist:

  • Branch: next is for changes and new documentation that will go public with the next ESPHome release. Fixes, changes and adjustments for the current release should be created against current.

Copy link
Member

@OttoWinter OttoWinter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • If you don't add this file to index.rst, it won't show up on the front page. It needs to be added there in the cookbook section.

cookbook/ifan02.rst Outdated Show resolved Hide resolved
cookbook/ifan02.rst Show resolved Hide resolved
cookbook/ifan02.rst Outdated Show resolved Hide resolved
cookbook/ifan02.rst Outdated Show resolved Hide resolved
cookbook/ifan02.rst Outdated Show resolved Hide resolved
cookbook/ifan02.rst Show resolved Hide resolved
cookbook/ifan02.rst Show resolved Hide resolved
cookbook/ifan02.rst Outdated Show resolved Hide resolved
@CallMeAreks
Copy link

Hi. Is this example correct? I have the ifan02 already mounted so I wanted to confirm if it's working as intended before flashing via OTA.

@workingmanrob
Copy link
Contributor

Hey @CallMeAreks

I've been using Quazzie's cookbook for a couple months now without issue.

I was running Tasmota firmware on my sonoff fan02 so I downloaded the esphome firmware after I built it then used the tasmota web UI to flash and everything is working as expected.

@CallMeAreks
Copy link

@workingmanrob Thank you for the confirmation. I tried it as well like a week ago, (leap of faith because I have 4 already installed ifan02), but work flawlessly. Forgot to leave a comment, though.

@pstechsolutions
Copy link

Not sure what made my case different. I had an issue during compile where I would get an error about only being allowed to register sub-components. The solution: In the ifan02.h file the line

class IFan02Output : public output::FloatOutput {

needed to be

class IFan02Output : public Component, public output::FloatOutput {

@OttoWinter and @quazzie Thank you both for your efforts and making them available for those of us, like myself, who are just learning!

@CallMeAreks
Copy link

@pstechsolutions Yeah, now that you mention this I noticed the code in this commit history is slightly different from the one I copied: https://gist.github.com/quazzie/09ee3ef2c419ecbcf979a7410062481b

In this gist it reflects the change you made. Leaving the link here for future reference.

@workingmanrob
Copy link
Contributor

Updated to 1.13.2 am now getting a valication error:

Unknown value 'MEDIUM', did you mean 'MEDIuM'?

Pretty sure I mean MEDIUM and trying to use MEDIuM instead gave the same error.

Any ideas?

@workingmanrob
Copy link
Contributor

Looks like 1.13.3 fixed it.. thanks Otto!

mjoshd and others added 7 commits September 14, 2019 11:14
Tried compiling this code today using ESPHome 1.13.6.. it would not compile. 

* The ifan02.h file was the main culprit and I was able to fix the issue.

* The .yaml example was missing a few declarations at the beginning so I added them.
* I fixed an error related to using ```light``` for the light id since that is a reserved name.
* I added an ```on_boot``` declaration to turn off the light as early as possible after power is restored. (if mains power is restored in the middle of the night and the light turns on while you are sleeping it can be quite annoying, this turns it off during the boot process).
Complete the example code & fix compilation errors
Those blank spaces get me every time ;-)
removed blank spaces on line 66
I think my last PR was made against the wrong fork/branch/etc... sorry, I'm still learning github.
I currently have the time and really want to see this make it into the cookbook. I think if you add me as a collaborator I would be able to push the changes and help get the errors sorted more quickly; if not, no worries, I'll take no offense and do my best to continue helping as we are doing now.
fix doc links (in the right repo)
replace
```
:doc:`/components/fan`
```
with
```
:doc:`/components/fan/index`
```
@mjoshd
Copy link
Contributor

mjoshd commented Sep 15, 2019

All is good now!

@quazzie Thanks for letting me assist!

@OttoWinter I have successfully compiled and installed this on my iFan02 with ESPHome 1.13.6 and it works 100% perfectly. Please merge this into the docs so others may benefit from it as well.

Have a great day everyone! 😃

@stale
Copy link

stale bot commented Nov 15, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Nov 15, 2019
@quazzie
Copy link
Contributor Author

quazzie commented Nov 16, 2019

It's only stale because @OttoWinter has not responded.

@stale stale bot removed the stale label Nov 16, 2019
@stale
Copy link

stale bot commented Jan 15, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jan 15, 2020
@quazzie
Copy link
Contributor Author

quazzie commented Jan 15, 2020

Still not stale @OttoWinter

@stale stale bot removed the stale label Jan 15, 2020
@stale
Copy link

stale bot commented Mar 15, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Mar 15, 2020
@quazzie
Copy link
Contributor Author

quazzie commented Mar 16, 2020

I guess it must be stale as nothing is happening...

@stale stale bot removed the stale label Mar 16, 2020
@mjoshd
Copy link
Contributor

mjoshd commented Mar 16, 2020 via email

@glmnet glmnet merged commit 00abf8b into esphome:current Apr 5, 2020
@quazzie quazzie deleted the ifan02 branch April 5, 2020 17:21
@lock lock bot locked and limited conversation to collaborators Apr 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants