Fix typos in pmsa003i.rst #3207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These values refer to "particulate matter count" > <particle size>, not less than
✅ Deploy Preview for esphome ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
11 tasks
jesserockz
approved these changes
Sep 24, 2023
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
These values refer to "particulate matter count" > , not less than.
The existing documentation at the bottom of the page:
https://esphome.io/components/sensor/pmsa003i.html
in the "Config" section is correct. For some reason, the example got the names mixed up.
Another source for the same info:
https://cdn-shop.adafruit.com/product-files/4632/4505_PMSA003I_series_data_manual_English_V2.6.pdf
(page 13-14)
The same typos exist in the code (will cut another PR for that):
https://github.com/esphome/esphome/blob/0ca8dcd08e96b431f8034acc16a7f9c2ab64eb84/esphome/components/pmsa003i/pmsa003i.h#L25
https://github.com/esphome/esphome/blob/0ca8dcd08e96b431f8034acc16a7f9c2ab64eb84/esphome/components/pmsa003i/pmsa003i.cpp#L61
Fixed that is this PR: esphome/esphome#5425
Related issue (if applicable): fixes
Pull request in esphome with YAML changes (if applicable): esphome/esphome#
Checklist:
I am merging into
nextbecause this is new documentation that has a matching pull-request in esphome as linked above.or
I am merging into
currentbecause this is a fix, change and/or adjustment in the current documentation and is not for a new component or feature.Link added in
/index.rstwhen creating new documents for new components or cookbook.