-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document the modbus server feature #3332
Conversation
✅ Deploy Preview for esphome ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
0b816f5
to
e0b30d3
Compare
e0b30d3
to
91af90d
Compare
91af90d
to
ca0ff25
Compare
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. Thank you for your contributions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fixed the conflicts, but still, there's a contradiction:
modbus_controller.rst
To choose the role, set the role attribute of the Modbus Component upon which this modbus_controller component relies. client is the default.
modbus.rst
role (Optional, string): The role of this component, client or server. Defaults to server.
I'll let the author to clear this...
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Description:
Related issue (if applicable): fixes esphome/feature-requests#708
Pull request in esphome with YAML changes (if applicable): esphome/esphome#4874
Checklist:
I am merging into
next
because this is new documentation that has a matching pull-request in esphome as linked above.or
I am merging into
current
because this is a fix, change and/or adjustment in the current documentation and is not for a new component or feature.Link added in
/index.rst
when creating new documents for new components or cookbook.