Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document the modbus server feature #3332

Merged
merged 5 commits into from
May 22, 2024

Conversation

JeroenVanOort
Copy link
Contributor

Description:

Related issue (if applicable): fixes esphome/feature-requests#708

Pull request in esphome with YAML changes (if applicable): esphome/esphome#4874

Checklist:

  • I am merging into next because this is new documentation that has a matching pull-request in esphome as linked above.
    or

  • I am merging into current because this is a fix, change and/or adjustment in the current documentation and is not for a new component or feature.

  • Link added in /index.rst when creating new documents for new components or cookbook.

Copy link

netlify bot commented Nov 5, 2023

Deploy Preview for esphome ready!

Name Link
🔨 Latest commit 1ef9f67
🔍 Latest deploy log https://app.netlify.com/sites/esphome/deploys/664d6de6ac4d630008502a52
😎 Deploy Preview https://deploy-preview-3332--esphome.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Feb 3, 2024

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. Thank you for your contributions.

@github-actions github-actions bot added the stale label Feb 3, 2024
@nagyrobi nagyrobi added not-stale and removed stale labels Feb 3, 2024
Copy link
Member

@nagyrobi nagyrobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed the conflicts, but still, there's a contradiction:

modbus_controller.rst

To choose the role, set the role attribute of the Modbus Component upon which this modbus_controller component relies. client is the default.

modbus.rst

role (Optional, string): The role of this component, client or server. Defaults to server.

I'll let the author to clear this...

@esphome esphome bot marked this pull request as draft February 24, 2024 12:17
@esphome
Copy link

esphome bot commented Feb 24, 2024

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

components/modbus.rst Outdated Show resolved Hide resolved
@jesserockz jesserockz dismissed nagyrobi’s stale review May 22, 2024 04:01

Conflict fixed to match code PR

@jesserockz jesserockz marked this pull request as ready for review May 22, 2024 04:01
@esphome esphome bot requested a review from jesserockz May 22, 2024 04:01
@jesserockz jesserockz merged commit 8fba0d2 into esphome:next May 22, 2024
2 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators May 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants