Hbridge christmas light #733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
jesserockz
previously requested changes
Oct 11, 2020
There was a problem hiding this comment.
Hey @DotNetDann, looks good, but could you please check your branching as there are some other commits included in here that should not be.
bringing christmas lights into esphome
DotNetDann
force-pushed
the
hbridge-christmas-light
branch
from
eebece3
to
5267e01
Compare
jesserockz
reviewed
Nov 3, 2020
Comment on lines
+43
to
+47
| - **id** (*Optional*, :ref:`config-id`): Manually specify the ID used for code generation. | ||
| - **name** (**Required**, string): The name of the light. | ||
| - **pin_a** (**Required**, :ref:`config-id`): The id of the first float :ref:`output` to use for this light. | ||
| - **pin_b** (**Required**, :ref:`config-id`): The id of the second float :ref:`output` to use for this light. | ||
| - All other options from :ref:`Light <config-light>`. |
There was a problem hiding this comment.
If the update_interval works from my comments on the code PR add the update_interval config option here with a description
There was a problem hiding this comment.
Not done. Unable to use polling_component_schema
jesserockz
approved these changes
Nov 8, 2020
This was referenced Jan 7, 2021
Merged
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bringing Christmas lights into esphome
Description:
Little Tuya modules are now in Christmas lights. These normally have a hbringe so they can skimp on the long cable costs.
e.g. https://mirabellagenio.net.au/festive-lights
Pull request in esphome with YAML changes (if applicable): esphome/esphome#1251
Checklist:
nextis for changes and new documentation that will go public with the next ESPHome release. Fixes, changes and adjustments for the current release should be created againstcurrent./index.rstwhen creating new documents for new components or cookbook.