Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs for homeassistant.tag_scanned action #763

Merged
merged 3 commits into from Sep 20, 2020

Conversation

jesserockz
Copy link
Member

Description:

Add docs for homeassistant.tag_scanned action

Related issue (if applicable): fixes

Pull request in esphome with YAML changes (if applicable): esphome/esphome#1281

Checklist:

  • Branch: next is for changes and new documentation that will go public with the next ESPHome release. Fixes, changes and adjustments for the current release should be created against current.
  • Link added in /index.rst when creating new documents for new components or cookbook.

Copy link
Member

@OttoWinter OttoWinter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, would be best if we can also update the pn532 docs with an example.

@jesserockz
Copy link
Member Author

LGTM, would be best if we can also update the pn532 docs with an example.

@OttoWinter Want me to add one in this PR?

@OttoWinter
Copy link
Member

Doesn't matter, can be here or in a separate PR. Let me know when you're ready to merge.

@jesserockz
Copy link
Member Author

I'll add in another one then tomorrow as I am heading off to bed now.
Thanks

@glmnet
Copy link
Member

glmnet commented Sep 20, 2020

I'd say add the example to https://esphome.io/components/binary_sensor/rdm6300.html for completeness

@glmnet glmnet merged commit 1494ca6 into esphome:next Sep 20, 2020
@glmnet glmnet mentioned this pull request Sep 20, 2020
glmnet pushed a commit that referenced this pull request Sep 20, 2020
* Add docs for homeassistant.tag_scanned

* Add pn532 example

* Add example to rdm6300
@glmnet glmnet mentioned this pull request Sep 20, 2020
SenexCrenshaw pushed a commit to SenexCrenshaw/esphome-docs that referenced this pull request Feb 13, 2021
* Add docs for homeassistant.tag_scanned

* Add pn532 example

* Add example to rdm6300
SenexCrenshaw pushed a commit to SenexCrenshaw/esphome-docs that referenced this pull request Feb 13, 2021
* Add docs for homeassistant.tag_scanned

* Add pn532 example

* Add example to rdm6300
SenexCrenshaw pushed a commit to SenexCrenshaw/esphome-docs that referenced this pull request Feb 13, 2021
* Add docs for homeassistant.tag_scanned

* Add pn532 example

* Add example to rdm6300
@github-actions github-actions bot locked and limited conversation to collaborators Oct 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants