Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HM3301 - Change type to calculation_type #769

Merged
merged 1 commit into from Sep 27, 2020

Conversation

rdehuyss
Copy link
Contributor

According to the esphome dashboard, AQI type should be calculation_type

Description:

Related issue (if applicable): fixes

Pull request in esphome with YAML changes (if applicable): esphome/esphome#

Checklist:

  • Branch: next is for changes and new documentation that will go public with the next ESPHome release. Fixes, changes and adjustments for the current release should be created against current.
  • Link added in /index.rst when creating new documents for new components or cookbook.

According to the esphome dashboard, AQI type should be calculation_type
@donnlee
Copy link

donnlee commented Sep 23, 2020

Yes, we need this PR. Right now ESPhome is throwing "calculation_type is required" error.

Copy link
Member

@jesserockz jesserockz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@jesserockz jesserockz merged commit 5ca367d into esphome:current Sep 27, 2020
This was referenced Oct 23, 2020
honomoa pushed a commit to honomoa/esphome-docs that referenced this pull request Nov 12, 2020
According to the esphome dashboard, AQI type should be calculation_type
stubs12 pushed a commit to stubs12/esphome-docs that referenced this pull request Dec 3, 2020
According to the esphome dashboard, AQI type should be calculation_type
@github-actions github-actions bot locked and limited conversation to collaborators Oct 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants