Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs: Add references to alternative ICs to HLW8012 and CSE7766 #902

Merged
merged 1 commit into from May 9, 2021
Merged

Update docs: Add references to alternative ICs to HLW8012 and CSE7766 #902

merged 1 commit into from May 9, 2021

Conversation

kubik369
Copy link
Contributor

@kubik369 kubik369 commented Dec 28, 2020

Description:

I have been banging my head for a whole day why my smart plug wasn't working with the CSE7759 (HLW8012) integration. After a while, I have found out that CSE7759 and CSE7759B are drastically different in terms of communication - pulses vs UART, HLW8012 vs CSE7766 integrations.

I think that cross-referencing CSE7766 (CSE7759B) documentation from the HLW8012 (CSE7759) documentation would be a good idea because it is otherwise a little confusing as there were originally
no references to the alternative IC names. I have implemented this documentation change in this pull request.

I have added references to power measurement IC sensors which are functionally identical:

  • CSE7759 and BL0937 to HLW8012 documentation
  • CSE7759B to CSE7766 documentation

Related issue (if applicable): N/A

Pull request in esphome with YAML changes (if applicable): N/A

Checklist:

  • Branch: next is for changes and new documentation that will go public with the next ESPHome release. Fixes, changes and adjustments for the current release should be created against current.
  • Link added in /index.rst when creating new documents for new components or cookbook.

Copy link
Contributor

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @kubik369!

That is a great first-time addition to the documentation! 🥇

../Frenck 🚂

@frenck frenck merged commit fc793e0 into esphome:current May 9, 2021
@kubik369 kubik369 deleted the update-cse7759b branch May 9, 2021 22:02
This was referenced May 11, 2021
This was referenced May 18, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Oct 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants