Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some max7219 updates. #1021

Merged
merged 2 commits into from May 1, 2020
Merged

Some max7219 updates. #1021

merged 2 commits into from May 1, 2020

Conversation

buxtronix
Copy link
Contributor

Description:

Explicitly disable test mode on setup. Also allow dynamic brightness updates in e.g lambdas.

Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#546

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

@glmnet
Copy link
Member

glmnet commented May 1, 2020

LGTM

@glmnet
Copy link
Member

glmnet commented May 1, 2020

Thanks

@glmnet glmnet merged commit 4f2e2fa into esphome:dev May 1, 2020
@lock lock bot locked and limited conversation to collaborators May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
integration: max7219
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@buxtronix @glmnet @OttoWinter