Add MCP4725 DAC Component #1418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
GTM when codeowners and test added, docs too, thanks! |
|
Thanks!! |
|
Thanks to you @glmnet, i planned to add tests but i was too busy last month 👍 |
|
Wanted to leave my thanks also - Im also keen to use this peripheral! |
taquitos
pushed a commit
to taquitos/esphome
that referenced
this pull request
Mar 14, 2021
* Add MCP4725 DAC * Fix lint * Fix lint * Fix lint * Lint & cleanup * Lint again * One more lint * add test Co-authored-by: Guillermo Ruffino <glm.net@gmail.com>
This was referenced May 3, 2021
Merged
Closed
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Related issue (if applicable): fixes esphome/feature-requests#1031
Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#889
Checklist:
tests/folder).If user exposed functionality or configuration variables are added/changed: