Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix servo not reattaching with same target #1649

Merged
merged 1 commit into from Mar 29, 2021

Conversation

glmnet
Copy link
Member

@glmnet glmnet commented Mar 29, 2021

What does this implement/fix?

Fixes servo not attaching if detached and commanded with the same value again

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Configuration change (this will require users to update their yaml configuration files to keep working)

Related issue or feature (if applicable): fixes esphome/issues#1620

Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#

Test Environment

  • ESP32
  • ESP8266
  • Windows
  • Mac OS
  • Linux

Explain your changes

Added additional call to internal_write to cover this edge case.

Describe your changes here to communicate to the maintainers why we should accept this pull request.
Very important to fill if no issue linked

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

@glmnet glmnet merged commit ad76312 into esphome:dev Mar 29, 2021
@jesserockz jesserockz added this to the 1.17.1 milestone May 5, 2021
This was referenced May 5, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Sep 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Calling servo.detach once on ESP32 renders further commands effectless - is this intended?
2 participants