New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for more EZO sensor commands #1865
Conversation
Friendly ping @ssieb - can you take a look at this? :) Code LGTM 👍 |
static const uint16_t CAL_SINGLE = 0; | ||
static const uint16_t CAL_LOW = 1; | ||
static const uint16_t CAL_MEDIUM = 2; | ||
static const uint16_t CAL_HIGH = 3; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change this to an enum and move it to the .h file.
Add descriptions of the new methods to the doc page. |
@ssieb Thank you for the improvement. Any commitment on when the documentation will be updated. ? |
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. Thank you for your contributions. |
What does this implement/fix?
Add support for calibrating EZO probes and for setting probe type (relevant for EC probe). Calibration can happen using a single value or multi-point calibration (support varies across probe types)
Types of changes
Test Environment
Explain your changes
There have been various debates to support more commands (specifically calibration) on these sensors since this needs to happen every couple of months. Currently support for EZO commands was limited to temperature compensation. This PR adds support for:
Note that this is my first time writing C++ code. So happy to get feedback.
Checklist:
tests/
folder).