Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More VSCode devcontainer improvements #1934

Merged
merged 3 commits into from Jun 22, 2021

Conversation

agners
Copy link
Contributor

@agners agners commented Jun 17, 2021

What does this implement/fix?

Quick description and explanation of changes

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

Related issue or feature (if applicable): fixes

Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#

Test Environment

  • ESP32
  • ESP8266

Example entry for config.yaml:

# Example config.yaml

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

This allows to build the devcontainer even when .pio is owned by root
from a previous devcontainer run.
@project-bot project-bot bot added this to Needs Review in ESPHome Dev Jun 17, 2021
@agners
Copy link
Contributor Author

agners commented Jun 17, 2021

@dentra maybe you can have a look at this changes.

ESPHome Dev automation moved this from Needs Review to Reviewer Approved Jun 18, 2021
Copy link
Member

@jesserockz jesserockz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@dentra
Copy link
Contributor

dentra commented Jun 22, 2021

@dentra maybe you can have a look at this changes.

looks great!

additionally at my opinion it would be nice to add running script/quicktest

@OttoWinter OttoWinter merged commit 32f2da7 into esphome:dev Jun 22, 2021
ESPHome Dev automation moved this from Reviewer Approved to Done Jun 22, 2021
@OttoWinter
Copy link
Member

additionally at my opinion it would be nice to add running script/quicktest

yeah some of the helper scripts would be good too - but we can add those later

This was referenced Jul 14, 2021
This was referenced Jul 21, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Sep 14, 2021
ESPHome Dev automation moved this from Done to Reviewer Approved Sep 23, 2023
ESPHome Dev automation moved this from Reviewer Approved to Done Sep 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants