Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add panasonic ac climate component #1998

Closed
wants to merge 11 commits into from

Conversation

WeekendWarrior1
Copy link
Contributor

@WeekendWarrior1 WeekendWarrior1 commented Jul 10, 2021

What does this implement/fix?

I have been using esphome to control my Panasonic AC (via IR) for over a year with a custom component, thought it was finally time to get an official component going. Tested and working on my AC.
Currently doesn't do any of the Panasonic presets "eg. eco, quiet, powerful", they seem to really mangle the IR packet.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

Related issue or feature (if applicable):

Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#1301

Test Environment

  • ESP32
  • ESP8266

Example entry for config.yaml:

# Example config.yaml
remote_receiver:
  id: rcvr
  pin:
    number: GPIO18
    inverted: True
    mode: INPUT_PULLUP
  # high 55% tolerance is recommended for some remote control units
  tolerance: 55%

remote_transmitter:
  pin:
    number: GPIO21
    inverted: True
  carrier_duty_percent: 50%

climate:
  - platform: panasonic
    name: "Lounge AC"
    receiver_id: rcvr
    supports_horizontal_swing: true

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

@jesserockz
Copy link
Member

Awesome!!
Finally something I actually have in my house I can test =)
I just quickly built a receiver and transmitter and tested this and it worked first time.

@WeekendWarrior1
Copy link
Contributor Author

Excellent, I am glad to hear. I will fix the failed lint and add to the docs in the coming days.

@jesserockz
Copy link
Member

jesserockz commented Jul 11, 2021

The ON/OFF byte is different for my unit though, could be because it should only look at/set a single bit in message[5] Mine works with 0x0A/0x0B instead of 0x08/0x09.
I also have added horizontal/vertical/both swing support locally so far as mine supports that.

@WeekendWarrior1
Copy link
Contributor Author

WeekendWarrior1 commented Jul 11, 2021

What model is your AC, and what does your remote look like?
The ones in my home are the CS-MRE7QKR, and my remote is:
image

I also have added horizontal/vertical/both swing support locally so far as mine supports that.

Can you please elaborate on what you mean by this?
Did setting

    supports_horizontal_swing: true

In the climate config not make those swing modes visible in HA? (I believe it should)

@jesserockz
Copy link
Member

No, setting that did not work. But also I modified it to not use a define and allow setting of each mode from yaml. I can push this commit if you are interested?

IMG_20210712_124450469.jpg

Indoor unit: CS-E18NKR

@WeekendWarrior1
Copy link
Contributor Author

Please do!

@probot-esphome probot-esphome bot added the core label Jul 12, 2021
@probot-esphome
Copy link

Hey there @glmnet, mind taking a look at this pull request as its been labeled with an integration (climate_ir) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@jesserockz
Copy link
Member

Can we rename this platform to be panasonic_ir as there is an external component that uses the serial port that should eventually make its way into ESPHome. https://github.com/DomiStyle/esphome-panasonic-ac/tree/dev-cztacg1

@jesserockz jesserockz mentioned this pull request Aug 25, 2021
3 tasks
@github-actions
Copy link
Contributor

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. Thank you for your contributions.

@github-actions github-actions bot added the stale label Jan 12, 2022
@github-actions github-actions bot closed this Jan 20, 2022
ESPHome Dev automation moved this from Needs Review to Cancelled Jan 20, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jan 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
ESPHome Dev
Cancelled
Development

Successfully merging this pull request may close these issues.

IR Remote Climate Panasonic IR Transmitter climate support for Panasonic
3 participants