Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecation message for old climate swing mode methods #2003

Merged
merged 1 commit into from Jul 11, 2021

Conversation

oxan
Copy link
Member

@oxan oxan commented Jul 10, 2021

What does this implement/fix?

Copy/paste error I noticed ;)

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

Related issue or feature (if applicable): fixes

Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#

Test Environment

  • ESP32
  • ESP8266

Example entry for config.yaml:

# Example config.yaml

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

@probot-esphome
Copy link

Hey there @esphome/core, mind taking a look at this pull request as its been labeled with an integration (climate) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@oxan oxan requested a review from jesserockz July 10, 2021 22:10
Copy link
Member

@jesserockz jesserockz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

ESPHome Dev automation moved this from Needs Review to Reviewer Approved Jul 11, 2021
@jesserockz jesserockz merged commit 1f5c79b into esphome:dev Jul 11, 2021
ESPHome Dev automation moved this from Reviewer Approved to Done Jul 11, 2021
@oxan oxan deleted the submitted/fix-deprecation-message branch July 11, 2021 21:03
This was referenced Jul 14, 2021
This was referenced Jul 21, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Sep 14, 2021
ESPHome Dev automation moved this from Done to Reviewer Approved Sep 23, 2023
ESPHome Dev automation moved this from Reviewer Approved to Done Sep 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants