Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I2c fix #2460

Merged
merged 2 commits into from Oct 7, 2021
Merged

I2c fix #2460

merged 2 commits into from Oct 7, 2021

Conversation

martgras
Copy link
Contributor

@martgras martgras commented Oct 7, 2021

What does this implement/fix?

Quick description and explanation of changes

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

Related issue or feature (if applicable): fixes esphome/issues#2512
esphome/issues#2506

Test Environment

  • ESP32
  • ESP8266

Tested with ads1115, ina226, bme280, sht35

Example entry for config.yaml:

# Example config.yaml

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

@probot-esphome
Copy link

probot-esphome bot commented Oct 7, 2021

Hey there @esphome/core, mind taking a look at this pull request as it has been labeled with an integration (i2c) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

ESPHome Dev automation moved this from Needs Review to Reviewer Approved Oct 7, 2021
Copy link
Member

@OttoWinter OttoWinter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@OttoWinter OttoWinter merged commit 5461f87 into esphome:dev Oct 7, 2021
ESPHome Dev automation moved this from Reviewer Approved to Done Oct 7, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Oct 9, 2021
ESPHome Dev automation moved this from Done to Reviewer Approved Sep 23, 2023
ESPHome Dev automation moved this from Reviewer Approved to Done Sep 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Development

Successfully merging this pull request may close these issues.

Last dev not connecting to I2C devices or returning bad or 0 values
2 participants