Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pin/component switchup in SX1509 pin configuration #2593

Merged
merged 3 commits into from Oct 21, 2021

Conversation

oxan
Copy link
Member

@oxan oxan commented Oct 21, 2021

What does this implement/fix?

Also fix compilation & add it to tests.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

Related issue or feature (if applicable): fixes esphome/issues#2590

Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#

Test Environment

  • ESP32
  • ESP32 IDF
  • ESP8266

Example entry for config.yaml:

# Example config.yaml

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

@oxan oxan added this to the 2021.10.2 milestone Oct 21, 2021
@project-bot project-bot bot added this to Needs Review in ESPHome Dev Oct 21, 2021
@oxan oxan mentioned this pull request Oct 21, 2021
10 tasks
ESPHome Dev automation moved this from Needs Review to Reviewer Approved Oct 21, 2021
Copy link
Member

@OttoWinter OttoWinter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

@oxan
Copy link
Member Author

oxan commented Oct 21, 2021

This must be some kind of record, an issue that receives two PR's to fix it within 10 minutes ;)

@OttoWinter OttoWinter merged commit c0fc5b4 into esphome:dev Oct 21, 2021
ESPHome Dev automation moved this from Reviewer Approved to Done Oct 21, 2021
@oxan oxan deleted the misc/fix-sx1509 branch October 21, 2021 17:58
@OttoWinter OttoWinter mentioned this pull request Oct 22, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Oct 24, 2021
ESPHome Dev automation moved this from Done to Reviewer Approved Sep 23, 2023
ESPHome Dev automation moved this from Reviewer Approved to Done Sep 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Development

Successfully merging this pull request may close these issues.

SX1509 GPIO support broken in 2021.10
2 participants