-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create initial NSPanel component #2702
base: dev
Are you sure you want to change the base?
Conversation
Hey there @jesserockz, CODEOWNERS = ["@jesserockz"] And run (message by NeedsCodeownersLabel) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spelling nit: celcius -> celsius
Co-authored-by: Christopher Masto <chris@masto.com>
Is it currently working? Stopped compiling firmwares when switching to current stable version of ESPH
|
I verified by pulling standalone ESPH and seems to compile properly. Probbaly problem is within my homeassistant installation. |
@jesserockz what is missing in order to merge this PR? I’m using it since month now without any issue 😃 |
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. Thank you for your contributions. |
Not stale |
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. Thank you for your contributions. |
Not stale? |
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. Thank you for your contributions. |
Hi @jesserockz, Will this PR be merged someday? What if it is closed? Do I have to abandon ESPHome? Thank you |
I wonder is this NSPanel protocol written specifically to one device or there is more devices using it? |
Personally I ended up writing my own UI for my panels and have since moved to using that along with the standard Even if this PR closes, the external component will stay and I will not delete the branch. At some point I might make a standalone repository for this, but it will stay as an |
I find my NSPanel working well with ESPHome build on that PR as external component, original and other custom UIs for nextion display are working as well. Indeed I feel that there is still place for improvement, but I belevie it can be continiued here on the PR some day. There are some limitations, as it's not possible to use many of ESP features (like BLE) due to lack of memory, but functionality I would expect from normal NSPanel works good with HA integration. |
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. Thank you for your contributions. |
This is still under development and the structure might change
What does this implement/fix?
This creates a component to communicate with and control the NSPanel default UI that is shipped with the device.
Types of changes
Related issue or feature (if applicable): closes esphome/feature-requests#1469
Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#
Test Environment
Example entry for
config.yaml
:Checklist:
tests/
folder).If user exposed functionality or configuration variables are added/changed: