Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install test requirements in lint Docker image #2719

Merged
merged 1 commit into from Nov 14, 2021

Conversation

oxan
Copy link
Member

@oxan oxan commented Nov 14, 2021

What does this implement/fix?

Fixes esphome/issues#2707.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

Related issue or feature (if applicable): fixes

Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#

Test Environment

  • ESP32
  • ESP32 IDF
  • ESP8266

Example entry for config.yaml:

# Example config.yaml

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

@project-bot project-bot bot added this to Needs Review in ESPHome Dev Nov 14, 2021
ESPHome Dev automation moved this from Needs Review to Reviewer Approved Nov 14, 2021
@jesserockz jesserockz merged commit 04740fb into esphome:dev Nov 14, 2021
ESPHome Dev automation moved this from Reviewer Approved to Done Nov 14, 2021
@oxan oxan deleted the misc/lint-docker branch November 14, 2021 21:05
@github-actions github-actions bot locked and limited conversation to collaborators Nov 16, 2021
ESPHome Dev automation moved this from Done to Reviewer Approved Sep 23, 2023
ESPHome Dev automation moved this from Reviewer Approved to Done Sep 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
Development

Successfully merging this pull request may close these issues.

Docker container esphome/esphome-lint is missing black
2 participants