Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MLX90393 three-axis magnetometer #2770

Merged
merged 30 commits into from Feb 8, 2022
Merged

Conversation

functionpointer
Copy link
Contributor

@functionpointer functionpointer commented Nov 19, 2021

What does this implement/fix?

Adds support for the melexis MLX90393 magnetometer.
This integration does use an external library, but the library is designed with an abstraction layer for i2c.
This means it does not depend on Wire and uses esphome's i2c abstraction instead.
As a result, this integration should work just fine with multiple i2c buses and on esp-idf.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

Related issue or feature (if applicable): fixes

Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#1641

Test Environment

  • ESP32
  • ESP32 IDF
  • ESP8266

Example entry for config.yaml:

# Example config.yaml
sensor:
  - platform: mlx90393
    oversampling: 1
    filter: 0
    gain: "3X"
    x-axis:
      name: "mlxxaxis"
    y-axis:
      name: "mlxyaxis"
    z-axis:
      name: "mlxzaxis"
    temperature:
      name: "mlxtemp"

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

@probot-esphome
Copy link

Hey there @functionpointer,
Thanks for submitting this pull request! Can you add yourself as a codeowner for this integration? This way we can notify you if a bug report for this integration is reported.
In __init__.py of the integration, please add:

CODEOWNERS = ["@functionpointer"]

And run script/build_codeowners.py

(message by NeedsCodeownersLabel)

@functionpointer functionpointer marked this pull request as ready for review November 20, 2021 23:10
@functionpointer functionpointer changed the title Draft: MLX90393 three-axis magnetometer MLX90393 three-axis magnetometer Nov 20, 2021
ESPHome Dev automation moved this from Needs Review to In Review Jan 10, 2022
esphome/components/mlx90393/sensor.py Show resolved Hide resolved
esphome/components/mlx90393/sensor.py Outdated Show resolved Hide resolved
esphome/components/mlx90393/sensor.py Outdated Show resolved Hide resolved
esphome/components/mlx90393/sensor_mlx90393.cpp Outdated Show resolved Hide resolved
esphome/components/mlx90393/sensor.py Outdated Show resolved Hide resolved
esphome/components/mlx90393/sensor_mlx90393.h Outdated Show resolved Hide resolved
esphome/components/mlx90393/sensor_mlx90393.h Outdated Show resolved Hide resolved
@functionpointer
Copy link
Contributor Author

Should i make a 1.0.0 release for the library functionpointer/arduino-MLX90393 ?

@jesserockz
Copy link
Member

Should i make a 1.0.0 release for the library functionpointer/arduino-MLX90393 ?

Up to you =)

@functionpointer
Copy link
Contributor Author

Merge conflict solved.

esphome/components/mlx90393/sensor.py Outdated Show resolved Hide resolved
Co-authored-by: Jesse Hills <3060199+jesserockz@users.noreply.github.com>
ESPHome Dev automation moved this from In Review to Reviewer Approved Feb 8, 2022
@jesserockz jesserockz merged commit 397ef72 into esphome:dev Feb 8, 2022
ESPHome Dev automation moved this from Reviewer Approved to Done Feb 8, 2022
@jesserockz jesserockz mentioned this pull request Feb 9, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Feb 10, 2022
ESPHome Dev automation moved this from Done to In Review Sep 23, 2023
ESPHome Dev automation moved this from In Review to Reviewer Approved Sep 23, 2023
ESPHome Dev automation moved this from Reviewer Approved to Done Sep 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants